-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render bus stations more prominantly #4391
base: master
Are you sure you want to change the base?
Conversation
I am fairly critical of this for a number of reasons:
What would go a long way towards convincing me of the merits of this change is if you can show me how for normal use of the tag (as documented on the wiki) this change would have a positive effect on the map - in particular at relatively low latitudes where the map is dense. |
@imagico the bus stop and train station icons are currently both blue squares (buses are light blue, the transport color, while railway stations are darker), and in your alt-colors branch the stations are still the same color though buses have been changed to purple along with other transportation icons, matching with airports. Do you have other ideas about an icon change or color change that would help here? |
Well - the train station / train halt rendering is cartographically very different from the bus stop rendering because the symbol is located on the railway track which is always shown as context (OpenTopoMap here for example goes a step further and orients the symbol in direction of the railway track) while for the bus stop the symbol is more or less hanging in the air without a clear context - and it is not uncommon that at z16 it is not quite clear what road a bus stop is on (like here). The current strong color combined with the fairly heavy weight of the bus stop squares, the lack of context and the fact that bus stops tend to be mapped separately for both sides of the road so they tend to show up in pairs - this all leads to a less than optimal rendering result. And tagging of public transport has evolved quite a bit (though there is no full agreement among mappers on this of course). So i think it would be valuable if someone would look into if some better interpretation of mapping is possible within the constraints we have here, in particular for the early zoom levels (~z15-z17). This requires finding out which mapping and tagging techniques have broad acceptance and consistent use, what kind of contextualized styling could work at lower zoom levels and how that could be generated without too much computational costs and code complexity. I know that is a tough call - but IMO the direction in which we have the most room to improve here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest testing amenity=bus_station with the smaller icon at z14, and the text label at z15.
// use colors from SVG to allow for white background | ||
marker-clip: false; | ||
} | ||
[zoom < 16][zoom >=13] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we would have this part above, using [feature = 'amenity_bus_station'][zoom >= 13], then [zoom >= 16] below
Fixes #4390
This PR attempts to increase rendering for
amenity=bus_station
without making the map too busy. Between zoom levels 13 and 16,amenity=bus_station
will render as small blue squares, the width of each icon at each zoom level being identical torailway=halt
.This PR does not affect how bus stations render at zoom levels z>=16. Personally, however, I think it is worth noting how seamless the transition between the generic blue square and the bus station pictograph is when zooming in from z=15 to z=16.
Changes proposed in this pull request:
style/amenity-points.mss
to renderamenity=bus_station
at z>=13symbols/square.svg
at z<16railway=halt
Test rendering with links to the example places:
Los Angeles
Before
After
Pittsburgh
Before
After
Paris
Before:
Overpass Turbo query for
amenity=bus_station
:At z=13
At z=15
At z=16 (unchanged)