Use system's settings for default theme #41425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanclark I also removed the old deprecated setting for theme (it was marked to be removed in 15). I've removed the backports and will just make this change from v16+ |
ryanclark
approved these changes
May 13, 2024
rudream
approved these changes
May 15, 2024
Currently, if no user preferences are set, and no theme has been chosen on this device, the default is automatically "Light Theme". This change will instead defer to the system's preferred theme
avatus
force-pushed
the
avatus/system_theme
branch
from
76f51c8
to
dcbb211
Compare
This change makes 'unspecified' the default option for user preferences which will allow the frontend to assume "unspecified" means "use the system setting"
|
I updated to prevent the backend from making |
|
friendly ping @ryanclark @rudream |
ryanclark
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if no user preferences are set, and no theme has been chosen on this device, the default is automatically "Light Theme". This change will instead defer to the system's preferred theme
af334ef39917510e82f87b47b0e1fe40.mp4
changelog: The default theme of teleport now defers to the system's setting