Support decoding --reviewers
as plain-text JSON
#330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared-workflows bot currently only supports decoding the
--reviewers
flag as a base64-encoded JSON string. For example, rather thanthe tool requires the value as
ewogICJyZXZpZXdlci1ncm91cC0xIjogewogICAgInVzZXJuYW1lIjogewogICAgICAgIC4uLiAvLyBSZXBlYXQgZm9yIDEwMCsgbGluZXMK...
. For those of us who cannot base64-decode a string in their head, this is really difficult to read and debug.Previously this was needed because GHA environment variables/secrets do not "play nice" with structured multiline data. However, now that we're starting to use
env-loader
for these values, we can support plain-text JSON without issue.This change is fully backwards compatible with all current uses of the bot.