Skip to content

clarify links and attributes for dataloader batch spans #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PascalSenn merged 1 commit into from
Mar 7, 2026
+12 −3
Merged

clarify links and attributes for dataloader batch spans #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions spec/spans.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,18 @@ groups:
- Otherwise, this span SHOULD be a child of the `graphql.server`
span, or of the resolver execution span that triggered the batch dispatch.

The span SHOULD have links to all resolver execution spans that
contributed load requests to this batch, so that the causal
relationship between resolvers and the batch is preserved.
The span SHOULD have links to all `graphql.field.execution` spans
whose resolvers contributed load requests to this batch, so that
the causal relationship between resolvers and the batch is preserved.

Each link SHOULD include the following attributes:
- `graphql.selection.field.coordinate`: The coordinate of the field
that triggered the load request (e.g., `User.avatar`).

When the number of contributing resolvers exceeds a practical limit,
instrumentations MAY cap the number of links to a configurable
maximum. The `graphql.dataloader.batch.size` attribute still
reflects the true batch size regardless of link count.
attributes:
- ref: graphql.processing.type
requirement_level: required
Expand Down