test: accept non-null union implementing a nullable union interface field - #4851
Open
jayphelps wants to merge 1 commit into
Open
test: accept non-null union implementing a nullable union interface field#4851jayphelps wants to merge 1 commit into
jayphelps wants to merge 1 commit into
Conversation
…ield Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
|
@jayphelps is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds schema validation coverage for implementing a nullable union interface field with the non-null union (
SomeUnionType!implementingSomeUnionType).That case is already allowed by
isTypeSubTypeOf(Non-Null is unwrapped before the abstract-type check) and by specIsValidImplementationFieldType. The existing tests only covered it for scalars (String!/String) and for a nullable union member (SomeObject/SomeUnionType), not this combination.graphql-java recently found it did not accept this schema (#4467): the union check ran before Non-Null unwrapping, so
U!implementingUwas rejected even though the spec allows it. graphql-js already does the right thing. Pinning that down with a test makes the behavior explicit as as-designed, rather than an accident of the comparator order.Object and interface implementers, next to the existing "subset non-null Interface field type" tests.