Remove install job, use setup-node's yarn cache#4202
Merged
dimaMachina merged 2 commits intographql:mainfrom Apr 19, 2026
Merged
Remove install job, use setup-node's yarn cache#4202dimaMachina merged 2 commits intographql:mainfrom
install job, use setup-node's yarn cache#4202dimaMachina merged 2 commits intographql:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4202 +/- ##
=======================================
Coverage 63.96% 63.96%
=======================================
Files 35 35
Lines 3086 3086
Branches 948 948
=======================================
Hits 1974 1974
Misses 1107 1107
Partials 5 5 🚀 New features to boost your workflow:
|
setup-node's yarn cache makes yarn install fast enough that sharing node_modules across jobs via actions/cache isn't worth the complexity. also replaces styfle/cancel-workflow-action with native concurrency.
9adc36f to
1b2e644
Compare
install job, use setup-node's yarn cache
trevor-scheer
commented
Apr 19, 2026
dimaMachina
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We're already using the yarn cache in
setup-node, soyarn installis cheap. Cachingnode_modulesis extra work and possibly even slower.Changes
Remove
installstep that manually cachesnode_modules. Just runyarn installin jobs where it's needed.