Skip to content

Remove install job, use setup-node's yarn cache#4202

Merged
dimaMachina merged 2 commits intographql:mainfrom
trevor-scheer:trevor/fix-ci-cache-keys
Apr 19, 2026
Merged

Remove install job, use setup-node's yarn cache#4202
dimaMachina merged 2 commits intographql:mainfrom
trevor-scheer:trevor/fix-ci-cache-keys

Conversation

@trevor-scheer
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer commented Apr 18, 2026

Context

We're already using the yarn cache in setup-node, so yarn install is cheap. Caching node_modules is extra work and possibly even slower.

Changes

Remove install step that manually caches node_modules. Just run yarn install in jobs where it's needed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 18, 2026

⚠️ No Changeset found

Latest commit: af325fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.96%. Comparing base (4627bed) to head (af325fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4202   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files          35       35           
  Lines        3086     3086           
  Branches      948      948           
=======================================
  Hits         1974     1974           
  Misses       1107     1107           
  Partials        5        5           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

setup-node's yarn cache makes yarn install fast enough that sharing
node_modules across jobs via actions/cache isn't worth the complexity.
also replaces styfle/cancel-workflow-action with native concurrency.
@trevor-scheer trevor-scheer force-pushed the trevor/fix-ci-cache-keys branch from 9adc36f to 1b2e644 Compare April 19, 2026 00:08
@trevor-scheer trevor-scheer changed the title simplify CI: remove install job, use setup-node yarn cache Remove install job, use setup-node's yarn cache Apr 19, 2026
Comment thread .github/workflows/main-test.yml
@trevor-scheer trevor-scheer marked this pull request as ready for review April 19, 2026 20:49
@dimaMachina dimaMachina merged commit a518b42 into graphql:main Apr 19, 2026
14 checks passed
@trevor-scheer trevor-scheer deleted the trevor/fix-ci-cache-keys branch April 19, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants