Resolves External Argument Default Mismatch specification doesnt account for all arguments
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count for all arguments
Co-authored-by: Daniel Reynolds <[email protected]>
glen-84
reviewed
Jan 2, 2025
Comment on lines
+348
to
+349
| - The default value of {externalArgument} must be equal to all | ||
| {defaultValues}. |
There was a problem hiding this comment.
Assume defaults:
Schema A: 1
Schema B: 2
Schema C: 3 (external)
Wouldn't this compare:
3 with 1
3 with 2
3 with 3 (redundant)
i.e. External defaults shouldn't be included in defaultValues?
There was a problem hiding this comment.
does this change the outcome of the rule?
I more or less try to word the rules as simple as possible.
The actualy implementation of the rule would be completely different anyway i believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #78