AIOHTTPTransport default ssl cert validation add warning #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for aiohttp fails
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 3102 3144 +42
=========================================
+ Hits 3102 3144 +42 ☔ View full report in Codecov by Sentry. |
mariuskava
reviewed
Feb 17, 2025
Adding explicitely verify as True in tests in addition to the default behavior. Adding tests with provided client certificate.
It appears that it is not possible to disable ssl verification for this transport. This could get fixed too in the next major version.
leszekhanusz
changed the title
leszekhanusz
added a commit
to leszekhanusz/gql
that referenced
this pull request
Feb 18, 2025
leszekhanusz
added a commit
that referenced
this pull request
Feb 19, 2025
* Restrict graphql-core to <3.2.4 to fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #529 reported that the
AIOHTTPTransportdid not validate ssl certificates by default.This PR add tests for all transports to check the four possible cases using a self certificate:
A new major version will be made to change this default behavior. In the meantime This PR will add a warning for
AIOHTTPTransportfor the default case to warn users.Note that the tests also revealed that it was not possible to disable the certificate validation on the
WebsocketsTransport. This should also be changed in the next major version.