Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): pagination for allocation monitor gql queries #178

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(common): pagination for allocation monitor gql queries #178

merged 1 commit into from
May 23, 2024

Conversation

carlosvdr
Copy link
Contributor

Related to #128

@carlosvdr carlosvdr self-assigned this May 20, 2024
@carlosvdr carlosvdr linked an issue May 20, 2024 that may be closed by this pull request
Bug: indexer_allocations limited to first 1000 #128
Closed
aasseman
aasseman requested changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests aren't passing in CI:

test allocations::monitor::test::test_parses_allocation_data_from_network_subgraph_correctly has been running for over 60 seconds

gusinacio
gusinacio requested changes May 21, 2024
View reviewed changes
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/context/checks/allocation_id.rs Outdated Show resolved Hide resolved
common/src/subgraph_client/client.rs Show resolved Hide resolved
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited

Pull Request Test Coverage Report for Build 9213324217

Details

  • 118 of 153 (77.12%) changed or added relevant lines in 3 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 68.437%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/allocations/monitor.rs 72 79 91.14%
common/src/subgraph_client/client.rs 43 71 60.56%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 93.64%
common/src/subgraph_client/client.rs 2 85.17%
common/src/allocations/monitor.rs 16 73.08%
Totals Coverage Status
Change from base Build 9200950960: -0.8%
Covered Lines: 3699
Relevant Lines: 5405
💛 - Coveralls

@aasseman aasseman changed the title Add pagination fix(common): pagination for allocation monitor gql queries May 21, 2024
aasseman
aasseman requested changes May 21, 2024
View reviewed changes
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
aasseman
aasseman reviewed May 22, 2024
View reviewed changes
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
aasseman
aasseman requested changes May 23, 2024
View reviewed changes
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
aasseman
aasseman requested changes May 23, 2024
View reviewed changes
common/src/allocations/monitor.rs Outdated Show resolved Hide resolved
aasseman
aasseman approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman requested a review from gusinacio May 23, 2024 19:18
gusinacio
gusinacio approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit 8f1689f into main May 23, 2024
9 checks passed
@aasseman aasseman deleted the add-pagination branch May 23, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

@aasseman aasseman aasseman approved these changes

Assignees

@carlosvdr carlosvdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: indexer_allocations limited to first 1000
3 participants
@carlosvdr @gusinacio @aasseman