Subgraph composition spec version #5782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
changed the base branch from
master
to
zoran/subgraph-composition-rework-vid-wrap2
zorancv
changed the base branch from
zoran/subgraph-composition-rework-vid-wrap2
to
zoran/rename-structs
zorancv
changed the base branch from
zoran/rename-structs
to
zoran/subgraph-composition-rework-vid-wrap2
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
6 times, most recently
from
d8bea9d to
47176c8
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
2 times, most recently
from
81f0a57 to
133169c
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
4 times, most recently
from
961556b to
a49edb8
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
2 times, most recently
from
6cb3a0c to
3d25869
Compare
lutter
approved these changes
Jan 31, 2025
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
2 times, most recently
from
e05ae82 to
522d7f7
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
from
515fdbc to
e61452f
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-spec-version
branch
from
e5d997b to
c8d8103
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
from
e61452f to
1cb3401
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
3 times, most recently
from
7173051 to
46fa0f4
Compare
zorancv
force-pushed
the
zoran/subgraph-composition-spec-version
branch
from
c8d8103 to
a6b7647
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-rework-vid-wrap2
branch
from
46fa0f4 to
061b9c7
Compare
incrypto32
force-pushed
the
zoran/subgraph-composition-spec-version
branch
from
a6b7647 to
9fa915b
Compare
lutter
approved these changes
Feb 7, 2025
| GetScope::Store => entity == self.store.get(key).unwrap().map(Arc::new), | ||
| GetScope::Store => { | ||
| // Release build will never call this function and hence it's OK | ||
| // when that implementation is not correct. |
There was a problem hiding this comment.
What do you mean by 'not correct'? It seems correct to me, though a little slow because of the clone, but that's fine for debug builds
| // Changes the way the VID field is generated. It used to be autoincrement. Now its | ||
| // based on block number and the order of the entities in a block. The latter | ||
| // represents the write order across all entity types in the subgraph. | ||
| pub fn strict_vid_order(&self) -> bool { |
There was a problem hiding this comment.
That's the method that I would rename to has_vid_seq; the main reason is because InputSchema.strict_vid_order and EntityType.strict_vid_order mean slightly different things. You could also change the comment to (notice the ///)
/// Whether the table for this entity type uses a sequence for the `vid` or whether
/// `graph-node` sets them explicitly. See also [`InputSchema.strict_vid_order()`]
|
|
||
| pub fn strict_vid_order(&self) -> bool { | ||
| self.inner.spec_version >= SPEC_VERSION_1_3_0 | ||
| } |
There was a problem hiding this comment.
This might be a good comment for this method:
/// How the values for the VID field are generated.
/// When this is `false`, this subgraph uses the old way of autoincrementing `vid` in the database.
/// When it is `true`, `graph-node` sets the `vid` explicitly to a number based on block number
/// and the order in which entities are written, and comparing by `vid` will order entities by that order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to base
VIDgeneration onspec_versionso that both old and new way of generatingVIDwill work simultaneously in the single binary. Some code that was removed in #5737 is reintroduced here.