Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❄️ Graph Horizon and Subgraph Service ❄️ #944

Open
wants to merge 134 commits into
base: main
Choose a base branch
from
Open

❄️ Graph Horizon and Subgraph Service ❄️ #944

wants to merge 134 commits into from

Conversation

pcarranzav
Copy link
Member

No description provided.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Feb 20, 2024 •
edited

[WIP] Graph Horizon

Generated at commit: aba7ac591ceda1a68d15e3c57068b4a8d620b0eb

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
16
41
63
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone changed the title [WIP/Experimental] Horizon draft changes [WIP/Experimental] BREAKING CHANGE: Horizon draft changes Feb 20, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 21, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (b5e4129) to head (a94a455).
Report is 7 commits behind head on main.

❗ Current head a94a455 differs from pull request most recent head aba7ac5

Please upload reports for the commit aba7ac5 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files          46       46           
  Lines        2370     2370           
  Branches      426      426           
=======================================
  Hits         2197     2197           
  Misses        173      173
Flag Coverage Δ
unittests 92.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmigone tmigone force-pushed the horizon branch 2 times, most recently from 76aa677 to 33b5790 Compare March 14, 2024 18:40
@socket-security Socket Security
Copy link

socket-security bot commented Mar 14, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@changesets/[email protected] filesystem 0 177 kB changesets-release-bot
npm/@changesets/[email protected] environment, filesystem, shell 0 123 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 41.3 kB changesets-release-bot
npm/@changesets/[email protected] None 0 26 kB changesets-release-bot
npm/@changesets/[email protected] None 0 9.81 kB changesets-release-bot
npm/@changesets/[email protected] None 0 18.8 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 23.1 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 30.4 kB changesets-release-bot
npm/@changesets/[email protected] filesystem 0 14.6 kB changesets-release-bot
npm/@commitlint/[email protected] None 0 30.6 kB escapedcat
npm/@commitlint/[email protected] None 0 18.8 kB escapedcat
npm/@commitlint/[email protected] None 0 12.2 kB escapedcat
npm/@commitlint/[email protected] None 0 13.7 kB escapedcat
npm/@commitlint/[email protected] None 0 3.97 kB escapedcat
npm/@commitlint/[email protected] None 0 13.2 kB escapedcat
npm/@commitlint/[email protected] None 0 9.11 kB escapedcat
npm/@commitlint/[email protected] None 0 14.7 kB escapedcat
npm/@commitlint/[email protected] environment, filesystem +1 71.7 kB escapedcat
npm/@commitlint/[email protected] None 0 2.81 kB escapedcat
npm/@commitlint/[email protected] None 0 4.57 kB escapedcat
npm/@commitlint/[email protected] filesystem 0 12.4 kB escapedcat
npm/@commitlint/[email protected] None 0 12.4 kB escapedcat
npm/@commitlint/[email protected] None 0 86.5 kB escapedcat
npm/@commitlint/[email protected] None 0 2.79 kB escapedcat
npm/@commitlint/[email protected] None 0 3.98 kB escapedcat
npm/@commitlint/[email protected] None 0 27.2 kB escapedcat
npm/@manypkg/[email protected] environment, filesystem +1 159 kB manypkg-release-bot
npm/@manypkg/[email protected] environment, filesystem +1 52.8 kB manypkg-release-bot
npm/@types/[email protected] None 0 96.1 kB types
npm/@types/[email protected] None 0 760 kB types
npm/@types/[email protected] None 0 2.03 MB types
npm/[email protected] eval 0 1.02 MB esp
npm/[email protected] None 0 20.2 kB ljharb
npm/[email protected] None 0 3.06 kB zkochan
npm/[email protected] None 0 15.1 kB tecfu
npm/[email protected] environment +1 36.3 kB sindresorhus
npm/[email protected] None 0 14.9 kB bcoe
npm/[email protected] filesystem 0 13.7 kB oss-bot
npm/[email protected] filesystem 0 16.1 kB oss-bot
npm/[email protected] None +1 521 kB oss-bot
npm/[email protected] None 0 12.6 kB codex-
npm/[email protected] filesystem 0 78.5 kB d-fischer
npm/[email protected] None 0 550 kB david
npm/[email protected] None 0 668 kB david
npm/[email protected] None 0 538 kB david
npm/[email protected] None 0 693 kB david
npm/[email protected] None 0 11.5 kB sindresorhus
npm/[email protected] None 0 9.68 kB sindresorhus
npm/[email protected] environment 0 189 kB jonschlinkert
npm/[email protected] None 0 2.38 MB ljharb
npm/[email protected] None 0 13.9 kB ljharb
npm/[email protected] None 0 6.61 kB vilic
npm/[email protected] filesystem 0 26.4 kB bluelovers
npm/[email protected] None 0 14.3 kB ljharb
npm/[email protected] shell +1 38.5 kB oss-bot
npm/[email protected] environment, filesystem 0 5.86 kB sindresorhus
npm/[email protected] None 0 8.4 kB safebyte
npm/[email protected] None 0 3.86 kB zkochan
npm/[email protected] None 0 2.95 kB sindresorhus
npm/[email protected] eval Transitive: environment, filesystem +1 408 kB vitaly
npm/[email protected] None 0 7.35 kB jdalton
npm/[email protected] None 0 17.7 kB jdalton
npm/[email protected] None 0 17.7 kB jdalton
npm/[email protected] None 0 21.5 kB jdalton
npm/[email protected] None 0 11.4 kB jdalton
npm/[email protected] None +2 133 kB sindresorhus
npm/[email protected] None +1 52.3 kB gar
npm/[email protected] None 0 35.1 kB cspotcode
npm/[email protected] None 0 7.24 kB sindresorhus
npm/[email protected] None +1 16.4 kB sindresorhus
npm/[email protected] None 0 5.06 kB zkochan
npm/[email protected] None +1 64.7 kB sindresorhus
npm/[email protected] None 0 3.2 kB zkochan
npm/[email protected] None 0 4.34 kB sindresorhus
npm/[email protected] Transitive: environment, filesystem +2 338 kB tecfu
npm/[email protected] Transitive: environment, filesystem, shell +3 41.7 kB thejameskyle
npm/[email protected] None 0 556 kB david
npm/[email protected] None 0 6.27 kB sindresorhus
npm/[email protected] environment, filesystem 0 49.7 kB tecfu
npm/[email protected] None 0 4.19 kB zkochan

🚮 Removed packages: npm/@aashutoshrathi/[email protected], npm/@ampproject/[email protected], npm/@ardatan/[email protected], npm/@aws-sdk/[email protected], npm/@aws-sdk/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@colors/[email protected], npm/@cspotcode/[email protected], npm/@dabh/[email protected], npm/@eslint-community/[email protected], npm/@eslint-community/[email protected], npm/@eslint/[email protected], npm/@ethersproject/[email protected], npm/@fastify/[email protected], npm/@humanwhocodes/[email protected], npm/@humanwhocodes/[email protected], npm/@isaacs/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@noble/[email protected], npm/@noble/[email protected], npm/@pkgjs/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@pnpm/[email protected], npm/@scure/[email protected], npm/@smithy/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@ungap/[email protected], npm/@yarnpkg/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@tmigone tmigone force-pushed the horizon branch 4 times, most recently from 1b27dfa to cae2490 Compare March 21, 2024 20:37
@tmigone tmigone changed the title [WIP/Experimental] BREAKING CHANGE: Horizon draft changes [WIP] Horizon draft changes Apr 12, 2024
@tmigone tmigone changed the title [WIP] Horizon draft changes [WIP] Horizon changes Apr 12, 2024
Maikol and others added 13 commits June 4, 2024 12:59
@Maikol
chore: deployments tests
0ebdbae
@Maikol
chore: comments heading
646198e
@Maikol
chore: staking service provider tests
352d7f1
@Maikol
fix: vm.assume rejecting too many options
cec2639
@Maikol
chore: add set staking counterpart address
c26e06b
@tmigone
test: add tests for linked list library
d109bbc 
Signed-off-by: Tomás Migone <[email protected]>
@Maikol
chore: added more staking service provider tests
c8c4eeb
@Maikol
fix: remove MIN_PROVISION_SIZE from horizon staking
05de8aa
@Maikol
Merge pull request #980 from graphprotocol/mde/remove-minimum-provisi…
60faa92 
…on-size

fix: remove MIN_PROVISION_SIZE from horizon staking
@tmigone
test: add provision tracker tests
3a4507c 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
test: add GraphDirectory tests
783c6f7 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
test: add base data service tests
ec7a374 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
test: add upgradeable data service test
82cc903 
Signed-off-by: Tomás Migone <[email protected]>
pcarranzav
pcarranzav commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for now - still reviewing

packages/contracts/contracts/arbitrum/ITokenGateway.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/rewards/RewardsManager.sol Show resolved Hide resolved
packages/horizon/README.md Show resolved Hide resolved
pcarranzav
pcarranzav commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, still reviewing...

packages/horizon/contracts/data-service/DataService.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/data-service/extensions/DataServiceFees.sol Show resolved Hide resolved
packages/horizon/contracts/libraries/LinkedList.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/data-service/extensions/DataServiceFees.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/libraries/LinkedList.sol Show resolved Hide resolved
packages/horizon/contracts/libraries/LinkedList.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/libraries/LinkedList.sol Show resolved Hide resolved
pcarranzav
pcarranzav commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moar

packages/contracts/CHANGELOG.md Show resolved Hide resolved
packages/horizon/contracts/data-service/interfaces/IDataService.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/data-service/interfaces/IDataService.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/data-service/utilities/ProvisionManager.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/interfaces/IBridgeEscrow.sol Outdated Show resolved Hide resolved
packages/horizon/contracts/libraries/Denominations.sol Show resolved Hide resolved
pcarranzav
pcarranzav commented Jun 7, 2024
View reviewed changes
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments - finished going through the main Solidity code

packages/horizon/package.json Outdated Show resolved Hide resolved
packages/subgraph-service/contracts/DisputeManager.sol Outdated Show resolved Hide resolved
tmigone and others added 10 commits June 7, 2024 14:45
@tmigone
fix: bad import path for graph directory
9c6f70f 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
fix: feedback fixes
9cb27fe 
Signed-off-by: Tomás Migone <[email protected]>
@Maikol
chore: horizon allocation fix and tests (#981)
a7d8ec4
@Maikol
chore: horizon allocation with beneficiary test
04bf4c7
@Maikol
chore: horizon close collection with delegation fees
66f9767
@tmigone
fix: change delegation ratio to be a value instead of range
99c273e 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
fix: moar feedback fixes
1741ea2 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
fix: ensure rewards manager looks at subgraph service and staking for… (
6f376cd 
#982)

* fix: ensure rewards manager looks at subgraph service and staking for allos

Signed-off-by: Tomás Migone <[email protected]>

* fix: typo

Signed-off-by: Tomás Migone <[email protected]>

---------

Signed-off-by: Tomás Migone <[email protected]>
@tmigone
feat: use poi to create dispute
02a2fc3 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone
feat: use poi to create dispute id
aba7ac5 
Signed-off-by: Tomás Migone <[email protected]>
@tmigone tmigone marked this pull request as ready for review June 7, 2024 23:56
@tmigone tmigone changed the title [WIP] Graph Horizon Graph Horizon and Subgraph Service Jun 7, 2024
@tmigone tmigone changed the title Graph Horizon and Subgraph Service ❄️ Graph Horizon and Subgraph Service ❄️ Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigone tmigone tmigone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
horizon protocol change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pcarranzav @tmigone @Maikol