Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu in webmap #33

Open
wants to merge 27 commits into
base: v3
Choose a base branch
from

Conversation

jedrek0429
Copy link
Contributor

@jedrek0429 jedrek0429 commented Mar 29, 2024

Partially implements #9.

TODO:

  • better accessibility
  • disappear on dragmove
  • right clicking on the contextmenu should bring up the browser contextmenu
  • replace the switch case with a simple map that "gets" the configured items
  • fix the weird visual of the accessibility highlighting when hitting tab with the contextmenu open

@jedrek0429 jedrek0429 marked this pull request as draft March 30, 2024 09:53
webmap/src/control/ContextMenuControl.ts Outdated Show resolved Hide resolved
webmap/src/control/ContextMenuControl.ts Outdated Show resolved Hide resolved
webmap/src/settings/Lang.ts Outdated Show resolved Hide resolved
@granny granny marked this pull request as ready for review April 4, 2024 02:58
webmap/src/control/ContextMenuControl.ts Outdated Show resolved Hide resolved
webmap/src/control/ContextMenuControl.ts Show resolved Hide resolved
webmap/src/control/ContextMenuControl.ts Outdated Show resolved Hide resolved
webmap/src/control/ContextMenuControl.ts Show resolved Hide resolved
webmap/src/control/ContextMenuControl.ts Outdated Show resolved Hide resolved
@jedrek0429
Copy link
Contributor Author

jedrek0429 commented Apr 5, 2024

moved to PR body

there's still a few things left to do;

  1. better accessibility
  2. disappear on dragmove
  3. right clicking on the contextmenu should bring up the browser contextmenu
  4. replace the switch case with a simple map that "gets" the configured items
  5. fix the weird visual of the accessibility highlighting when hitting tab with the contextmenu open
    [...]

i think this is important to copy over as well: https://github.com/JLyne/LiveAtlas/blob/master/src/components/map/MapContextMenu.vue#L198-L213

@granny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants