forked from finos/architecture-as-code
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into sanitize-adr-inputs
- Loading branch information
Showing
12 changed files
with
1,349 additions
and
2,136 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,26 @@ | ||
--- | ||
name: 🚀 Feature Request | ||
about: I have a suggestion (and may want to implement it 🙂) | ||
name: 📋 New Project Proposal | ||
about: I have a new project proposal for the monorepo | ||
|
||
--- | ||
|
||
## Feature Request | ||
|
||
### Description of Problem: | ||
...what *problem* are you trying to solve that the project doesn't currently solve? | ||
...what feature will the new project have, and why do I want it? | ||
|
||
...please resist the temptation to describe your request in terms of a solution. Job Story form ("When [triggering condition], I want to [motivation/goal], so I can [outcome].") can help ensure you're expressing a problem statement. | ||
### Gap: | ||
...describe why this feature doesn't fit into an existing project | ||
|
||
### Potential Solutions: | ||
...clearly and concisely describe what you want to happen. Add any considered drawbacks. | ||
...provide clear detail of the intended implementation, including technology choices, fit of choices, etc. | ||
|
||
... if you've considered alternatives, clearly and concisely describe those too. | ||
### Onboarding Checklist | ||
The below must be completed before a new project is accepted into the monorepo: | ||
- [ ] `.github/CODEOWNERS` is updated to add your new module. You should use GitHub Teams for this rather than individuals. | ||
- [ ] Ensure workflow actions are added to `.github/workflows` that build/verify the module for any PR's with it in its blast radius. For example if your module depends on shared it should trigger build/tests on shared changes. | ||
- [ ] `README.md` updated with new module and owners. | ||
- [ ] If it's a typescript module - add into the root level `package.json` under `workspaces:` so that we can hoist shared dependencies and allow root level installs/builds etc. | ||
- [ ] New module should have a `README.md` documenting what the module does - how to develop for it and any other sort of contribution guidelines. | ||
- [ ] If the new module requires a new label for PR clarity ( https://github.com/finos/architecture-as-code/issues/783 ) - add this into `.github/labeler.yml` and if this is a new label please manually create it on GitHub. | ||
- [ ] Update the docs to include details of the new project for consumers. |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.