Skip to content

feat: plugins-e2e pre-navigate hook #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

shelldandy
Copy link
Contributor

@shelldandy shelldandy commented Mar 27, 2025

This PR helps fixtures enhance the navigate method by adding any sort of logic before the ctx.page.goto() call use cases can be:

  • Ensuring grafana menus are closed before anything else happens for consistent screenshot testing
  • Setting up localStorage variables needed for all tests of an app
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install [email protected]
npm install @grafana/[email protected]
npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add [email protected]
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@shelldandy shelldandy requested a review from a team as a code owner March 27, 2025 21:44
@shelldandy shelldandy requested a review from Ukochka March 27, 2025 21:44
@shelldandy shelldandy added minor Increment the minor version when merged release Create a release when this pr is merged labels Mar 27, 2025
@jackw jackw moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Mar 31, 2025
@shelldandy shelldandy requested a review from a team as a code owner April 14, 2025 14:13
Copy link
Contributor

Playwright test results

Image Name Version Result Report
grafana-dev 12.0.0-238150
grafana-enterprise 11.6.0
grafana-enterprise 11.3.5
grafana-enterprise 10.2.9
grafana-enterprise 9.2.20
grafana-enterprise 8.5.27
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

@shelldandy shelldandy closed this Apr 16, 2025
@github-project-automation github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged
Projects
Development

Successfully merging this pull request may close these issues.

1 participant