Scenes App: Update to use react-router v6 #1422
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
added
create-plugin
6 tasks
leventebalogh
force-pushed
the
leventebalogh/scenes-app/update-router
branch
from
33b15b8 to
1de8a5a
Compare
leventebalogh
moved this from 🧑💻 In development
to 📅 Planned
in Plugins Platform / Grafana Community
tolzhabayev
moved this from 📅 Planned
to 🧑💻 In development
in Plugins Platform / Grafana Community
|
This pull request has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@academo we can close this right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: grafana/scenes#979
Note
This PR is still using the
6.0.0--canary.979.12373078054.0canary version of the@grafana/scenespackage. It will get updated once the major version goes out.What changed?
This PR updates the scaffolded
scenes-apptemplate to use the v6 version of react-router as well.<Routes>instead<Switch>/*s for wildcard routes (routes are now exact by default)📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: