-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update _index.md: add information about non-blocking mode to the documentation #15910
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This info saves a lot of time for solving the issue when the Loki server is unavailable and containers become unmanageable and sometimes completely malfunctioning. This information can only be found in issues, but not in the documentation. Signed-off-by: Roked <[email protected]>
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Jan 23, 2025
Rokedd
changed the title
Update _index.md
Update _index.md: add information about non-blocking mode to the documentation
Jan 23, 2025
JStickler
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Hi @Rokedd , I find it's always helpful with Yaml files to give clear instructions on where snippets need to be nested.
JStickler
changed the title
Update _index.md: add information about non-blocking mode to the documentation
docs: Update _index.md: add information about non-blocking mode to the documentation
Jan 23, 2025
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Roked <[email protected]>
JStickler
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM
loki-gh-app bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…e documentation (#15910) Signed-off-by: Roked <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 10fef0c)
loki-gh-app bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…e documentation (#15910) Signed-off-by: Roked <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 10fef0c)
loki-gh-app bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…e documentation (#15910) Signed-off-by: Roked <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 10fef0c)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release-3.1.x
backport release-3.2.x
backport release-3.3.x
size/XS
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I struggled with the issue that after working for more than 10 minutes without an internet connection, all my containers froze and stopped working. I've spent a lot of time fixing this issue and I couldn't even find any mention of such a parameter in the documentation.
Thanks for https://community.grafana.com/t/loki-driver-on-docker-and-getting-stuck-container/56610/2
Which issue(s) this PR fixes:
If the Loki server is unavailable, the running containers run for 10 minutes and freeze. That is, everything that is running inside the container completely stops working, which is unacceptable in my opinion. I was also confused that the documentation doesn't even mention that there is such a log-opt!
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR