feat(ingest-limits): Add ExceedsLimit implementation #15884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
approved these changes
Jan 23, 2025
pkg/limits/frontend/service.go
Outdated
| for _, resp := range resps { | ||
| sum += resp.Response.(*logproto.GetStreamUsageResponse).ActiveStreams | ||
| if resp.Response == nil { |
There was a problem hiding this comment.
Is there a case where a resp.Response can be nil when err is also non-nil?
There was a problem hiding this comment.
No I guess it was just muscle memory to protect from nil rather than considering the code branches. This if-statement is obsolete.
pkg/limits/frontend/service.go
Outdated
| // recorded | ||
| for _, stream := range resp.Response.RecordedStreams { | ||
| if !uniqueStreamHashes[stream.StreamHash] { | ||
| uniqueStreamHashes[stream.StreamHash] = true |
There was a problem hiding this comment.
I find the code easier to read if we increment unique streams inside the if statement, instead of add the total and then subtract the duplicates. Is the latter much faster?
github-actions
bot
added
the
type/docs
|
💻 Deploy preview deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the
ExceedsLimitGRPC request handler for requesting stream counts per tenant. The implementation currently is:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR