Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to latest browser #3819

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jul 1, 2024

What?

Why?

To prevent potential race conditions.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.94%. Comparing base (95b1a5a) to head (a36569a).

Current head a36569a differs from pull request most recent head 51c5553

Please upload reports for the commit 51c5553 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3819      +/-   ##
==========================================
+ Coverage   71.92%   71.94%   +0.02%     
==========================================
  Files         291      291              
  Lines       21277    21277              
==========================================
+ Hits        15303    15308       +5     
+ Misses       4915     4911       -4     
+ Partials     1059     1058       -1     
Flag Coverage Δ
ubuntu 71.88% <ø> (+0.02%) ⬆️
windows 71.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inancgumus inancgumus force-pushed the browser/create-wait-for-event-fix branch from a307221 to 51c5553 Compare July 1, 2024 11:45
@inancgumus inancgumus changed the title Updates browser to main Updates to latest browser Jul 1, 2024
@inancgumus inancgumus marked this pull request as ready for review July 1, 2024 12:11
@inancgumus inancgumus requested a review from a team as a code owner July 1, 2024 12:11
@inancgumus inancgumus requested review from mstoykov and joanlopez and removed request for a team July 1, 2024 12:11
@inancgumus inancgumus self-assigned this Jul 1, 2024
@mstoykov mstoykov merged commit c682fa2 into master Jul 1, 2024
22 checks passed
@mstoykov mstoykov deleted the browser/create-wait-for-event-fix branch July 1, 2024 16:21
@mstoykov mstoykov added this to the v0.53.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants