Fixed Summary Generated Events #3730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameetpal
requested review from
codebien and
olegbespalov
and removed request for
a team
olegbespalov
previously approved these changes
May 3, 2024
There was a problem hiding this comment.
LGTM
@codebien and maybe @grafana/k6-core we might consider adding this into upcoming release
|
Hey @ameetpal We did release the k6 v0.51. Could you please rebase this PR using the latest |
|
Hey @olegbespalov , i have updated the branch, some random tests are failing, but are not related to my changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the shortcomings of TestSummaryGenerated Event :- #3682
Why?
The previously added TestSummaryGenerated had data in the form of a map with keys of type string and values of type io.Reader, however, the stream had already been read by stdout. Additionally, the data was formatted for console output, which was not consistent with what was expected by the handleSummary function of the test. Therefore, I returned the exact summary passed into the function and sent it as an event.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)