Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Static ports #3501

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

xogoodnow
Copy link
Contributor

Hi,

None of the service/port related configurations for gateway were actually dynamic.
Also changed the probe so the parameters could be configured

Cheers

Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Copy link
Contributor Author

I see that almost all other services (except for metrics-generator) are static.
Will change the templates

Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
@xogoodnow
Copy link
Contributor Author

xogoodnow commented Dec 22, 2024

I went through almost all services and mildly modified the templates so the ports could be modified dynamically.

  1. If the ports section are there so folks would be able to change the ports, they must not be set statically but if the section is just informative, we can commit them all and just provide a link to the documentation.
  2. This way changing any default port would be possible in the future

Cheers

Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant