-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] Static ports #3501
Open
xogoodnow
wants to merge
16
commits into
grafana:main
Choose a base branch
from
xogoodnow:configure-ports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
xogoodnow
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
December 22, 2024 16:19
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
I see that almost all other services (except for metrics-generator) are static. |
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
I went through almost all services and mildly modified the templates so the ports could be modified dynamically.
Cheers |
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
None of the service/port related configurations for gateway were actually dynamic.
Also changed the probe so the parameters could be configured
Cheers