[tempo-distributed] Misplaced proxy-target examples #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xogoodnow
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
Signed-off-by: xogoodnow <[email protected]>
xogoodnow
force-pushed
the
misplaced-proxy-target
branch
from
515ea31 to
1cad7cf
Compare
xogoodnow
changed the title
Signed-off-by: xogoodnow <[email protected]>
There was a problem hiding this comment.
Hey @xogoodnow could you please address the conflicts and then we could proceed to approving, Thanks for the PR though!!
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: Ali <[email protected]>
…placed-proxy-target # Conflicts: # charts/tempo-distributed/Chart.yaml # charts/tempo-distributed/README.md
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Hi @Sheikh-Abubaker, Done. Cheers |
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: Ali <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The examples for proxy-targets were listed out of order (in hostAliases section).