feat: generate Grafonnet for Grafana v11.0.0 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This will drop support for regenerating <v11.0.0 versions of Grafonnet, any backports will need manual intervention from here on.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was
linked to
issues
May 13, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
malcolmholmes
approved these changes
May 24, 2024
| @@ -282,7 +282,7 @@ PARAMETERS: | |||
| * **value** (`boolean`) | |||
| - default value: `true` | |||
|
|
|||
|
|
|||
| ?? default is missing or false ?? | |||
There was a problem hiding this comment.
That comes from the schemas, I just scanned for that sentence but can't find the source immediately, cc/ @K-Phoen, do you know?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, I'll leave it as such.
| @@ -378,6 +380,28 @@ PARAMETERS: | |||
| * **value** (`object`) | |||
|
|
|||
| TODO docs | |||
There was a problem hiding this comment.
todo? We've now got docs?
There was a problem hiding this comment.
That comes from the upstream schemas in grafana/grafana, authors of that panel should document this.
| @@ -19,7 +19,6 @@ jb init | |||
| cp -r "${REPO_DIR}/generator" generator | |||
| cp -r "${REPO_DIR}/generator/jsonnetfile.lock.json" . | |||
| jb install | |||
| jb install "github.com/grafana/grok/jsonnet/${VERSION}@main" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the generator to use foundation-sdk, this means the generator now only works for generating Grafonnet for Grafana v11+. If older generated libraries need updates/backporting, this'll require manual intervention.
Notable changes:
libraryPanelgrafonnet.query.exprAlertGroupspanel is no longer supported in Grafana v11withType(value) -> withType()Candlestickpanel: CandlestickFieldMap no longer nestedHeatmappanel: HeatmapTooltip, FilterValueRange, HeatmapColorOptions and CellValues no longer nestedTablepanel: TableFooterOptions no longer nestedPrometheusquery:scopefield got removedThere are a bunch more minor changes and docs updates.
Diff hint for the reviewer: