-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding maxPerRow for all panels and repeatDirection for row panel #140
Conversation
Vishnu Challa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
The files in It looks like the schema for the row panel is missing these fields. These functions can be added in this file: https://github.com/grafana/grafonnet/blob/main/custom/row.libsonnet |
Better would be an issue or PR against grafana/grafana to update the underlying schema. Then Grafonnet would automatically pick it up. |
55e0a7d
to
2861b5e
Compare
Grafana upstream already seems to be having these elements in their schema, as we can see them in the UI dashboard. |
Made these changes in schema as suggested instead of generated files. I am not sure why
|
@vishnuchalla You are missing jrsonnet |
Hey, sorry for letting this hang for so long. I've just been looking into this, trying to figure out why those fields aren't there. AFAICT these values don't make sense on a row panel, the direction is always vertical, regardless of the value in the json, that's just how rows work. The maxPerRow doesn't mean anything as nested rows don't exist. repeatDirection is available on panels: example maxPerRow fixed in #207 along with a few other fields. |
These two attributes are required for below reasons.