Improve the problem checking for the daemon-reuse test #29057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hegyibalint
added
a:chore
hegyibalint
changed the title
tresat
approved these changes
May 8, 2024
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
blindpirate
approved these changes
May 10, 2024
donat
requested changes
May 10, 2024
| @@ -116,7 +116,8 @@ class JavaCompilerDaemonReuseIntegrationTest extends AbstractCompilerDaemonReuse | |||
| } | |||
|
|
|||
| def "log messages from a compiler daemon are associated with the task that generates them"() { | |||
| def buildOperations = new BuildOperationsFixture(executer, temporaryFolder) | |||
| enableBuildOperationsFixture() | |||
There was a problem hiding this comment.
❌ It seems redundant as calling enableProblemsApiCheck() also calls enableBuildOperationsFixture()
There was a problem hiding this comment.
I wanted to keep it redundant, as removing the enableProblemsApiCheck() would remove the build fixture. This is more about telling the reader that we need that fixture.
| @@ -65,7 +65,7 @@ class KnownProblemIds { | |||
| 'compilation:java:java-compilation-error' : 'Java compilation error', | |||
| 'compilation:java:java-compilation-failed' : 'Java compilation error', | |||
| 'compilation:java:java-compilation-warning' : 'Java compilation warning', | |||
| 'compilation:java:java-compilation-advice' : 'Java compilation note', | |||
| 'compilation:java:java-compilation-note' : 'Java compilation note', | |||
There was a problem hiding this comment.
🤔 maybe compilation:java:java-compilation-info, or compilation:java:java-compilation-advice?
There was a problem hiding this comment.
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this test, which could use some help when it comes to problem checking.
In addition, I've made the
buildOperationFixtureprotected, so other tests could fetch the build operations coming in without the need to make the fixture themselves.