Introduce more checks for Declarative DSL: reassignment and block order #29028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
eskatos
reviewed
May 15, 2024
Comment on lines
119
to
120
| 'plugins' | 'pluginManagement { }\nplugins { }\nrootProject.name = "foo"\nplugins { }' | "" | ||
| 'pluginManagement' | 'pluginManagement { }\nplugins { }\nrootProject.name = "foo"\npluginManagement { }' | "" |
There was a problem hiding this comment.
❓ Is the empty error message intended?
There was a problem hiding this comment.
Nope, it was an oversight. Fixed in 73940b1 (#29028).
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
h0tk3y
force-pushed
the
sigushkin/declarative-dsl/checks
branch
from
73940b1
to
8bc9fcc
Compare
h0tk3y
force-pushed
the
sigushkin/declarative-dsl/checks
branch
from
8bc9fcc
to
74d589c
Compare
h0tk3y
force-pushed
the
sigushkin/declarative-dsl/checks
branch
from
74d589c
to
bd56f01
Compare
h0tk3y
force-pushed
the
sigushkin/declarative-dsl/checks
branch
from
ed1c3ca
to
d4a0a88
Compare
eskatos
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/gradle/gradle-private/issues/4166