Expand acceptable range of tanh #4392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoddicus
reviewed
May 21, 2025
There was a problem hiding this comment.
Looks fine to me, though you might need to regenerate the test cache, since the checks are failing.
I am not going to approve right now, since this is dependent on an upstream spec change, but adding @dneto0 incase that lands while I am away, so he can approve.
|
The command to re-generate the cache is |
added 2 commits
May 22, 2025 14:58
dneto0
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming this pr goes through
gpuweb/gpuweb#5199
crbug.com/390221422