Feat: enable new modal gpus 🚀 #286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables support for new modal GPUs for the application.
- Updated the GPU list in modal_runner_archs.py to include B200 and H200.
- Added H200 to the ModalGPU enum and its ranking criteria in consts.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/discord-cluster-manager/modal_runner_archs.py | Updated GPU list to include new GPU identifiers for modal execution. |
| src/discord-cluster-manager/consts.py | Added H200 to the ModalGPU enum and its corresponding rank mapping. |
msaroufim
reviewed
May 30, 2025
| @@ -115,6 +116,7 @@ class RankCriterion(Enum): | |||
| "L4": "80", | |||
| "A100": "80", | |||
| "H100": "90a", | |||
| "H200": "90a", | |||
There was a problem hiding this comment.
Don't have a strong opinion, probably not too interesting GPU so idc if we remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable H200 + B200 for Modal