Fix Timeout Bug #280
Open
Fix Timeout Bug #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a timeout bug in GitHub workflow submission by introducing mode-based timeout logic for different submission types.
- Introduces logic to select a timeout value based on the submission mode.
- Enhances logging to include the computed timeout value.
|
it seems you have moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr makes it such that we actually use the specified timeouts from github when running a submission. This logic was missing before. There's also a bunch of refactoring changes to make the linter happy.
Testing:
There is now a snippet in the logs that looks like
which indicates that we are passing a non default value. The associated workflow is https://github.com/gpu-mode/discord-cluster-manager/actions/runs/15033809006 (I believe the failure is noisy)