refactor: standardize yap classfiles on _yap.gox#183
refactor: standardize yap classfiles on _yap.gox#183aofei wants to merge 1 commit intogoplus:mainfrom
_yap.gox#183Conversation
Remove the `.yap` classfile entries from `gox.mod` and rename the yap demo and test files to `_yap.gox` so the repository matches the preferred classfile convention. Update the README, manual, and `ytest` docs to use `_yap.gox` examples and `xgo` commands throughout. Refresh the checked-in generated files and replace the leftover `gop_autogen` outputs in `ytest/demo/_example` with `xgo_autogen` files by updating the example to use the current bearer auth helper. Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on standardizing the naming convention for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring to standardize the yap classfile extension to _yap.gox. The changes include renaming numerous .yap files, updating the gox.mod configuration, and modifying documentation (README.md, doc/manual.md) to reflect the new convention and switch from gop to xgo commands. Additionally, autogenerated files have been refreshed across various demo projects, which also includes an update from an oauth2 helper to bearer.New in one of the examples. The changes appear to be consistent and systematically applied across the repository. The refactoring is thorough and aligns with the stated goal of standardizing classfile conventions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 8 8
Lines 852 852
=======================================
Hits 689 689
Misses 133 133
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Clean, well-scoped refactor. The rename from |
There was a problem hiding this comment.
Pull request overview
This PR standardizes YAP classfiles on the _yap.gox suffix and refreshes the repository’s checked-in generated outputs and documentation to match the updated XGo/YAP conventions.
Changes:
- Update
gox.modto remove legacy.yapentries and standardize the YAP project/classfile suffix on_yap.gox. - Rename/introduce demo and ytest classfiles using
_yap.goxand refresh correspondingxgo_autogen*.gooutputs (including updated//linemappings). - Update top-level docs (README/manual/ytest README) to reference
_yap.goxexamples and usexgocommands consistently; refresh ytest_exampleto use bearer auth and current matching helpers.
Reviewed changes
Copilot reviewed 19 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
gox.mod |
Removes .yap configuration and standardizes YAP classfile configuration on _yap.gox. |
README.md |
Updates docs/links/commands to _yap.gox and xgo workflows. |
doc/manual.md |
Updates classfile suffix explanations and demo links to _yap.gox / xgo. |
ytest/README.md |
Updates example links and installation command to xgo get and _yap.gox filenames. |
demo/classfile_hello/xgo_autogen.go |
Refreshes generated //line references to main_yap.gox. |
demo/classfile_hello/main_yap.gox |
Adds new _yap.gox classfile version of the hello demo. |
demo/classfile_blog/xgo_autogen.go |
Refreshes generated app type/entrypoint and //line references for new _yap.gox demo file. |
demo/classfile_blog/main_yap.gox |
Adds new _yap.gox classfile version of the blog demo entry. |
demo/classfile_nestetemplate/xgo_autogen.go |
Refreshes generated app type/entrypoint and //line references for new _yap.gox demo file. |
demo/classfile_nestetemplate/main_yap.gox |
Adds new _yap.gox classfile version of the nested-template demo entry. |
demo/classfile2_static/xgo_autogen.go |
Refreshes generated //line references to main_yap.gox. |
demo/classfile2_static/main_yap.gox |
Adds new _yap.gox classfile version of the static demo entry. |
demo/classfile2_statichttp/xgo_autogen.go |
Refreshes generated //line references to main_yap.gox. |
demo/classfile2_statichttp/main_yap.gox |
Adds new _yap.gox classfile version of the static-http demo entry. |
demo/classfile2_hello/xgo_autogen.go |
Refreshes generated handler mappings to get_yap.gox / get_p_#id_yap.gox. |
demo/classfile2_hello/get_yap.gox |
Adds new handler classfile in _yap.gox convention. |
demo/classfile2_hello/get_p_#id_yap.gox |
Adds new handler classfile in _yap.gox convention. |
demo/classfile2_blog/xgo_autogen.go |
Refreshes generated handler mappings to get_yap.gox / get_p_#id_yap.gox and main entry to main_yap.gox. |
demo/classfile2_blog/main_yap.gox |
Adds new _yap.gox classfile version of the blog v2 main entry. |
demo/classfile2_blog/get_yap.gox |
Adds new handler classfile in _yap.gox convention. |
demo/classfile2_blog/get_p_#id_yap.gox |
Adds new handler classfile in _yap.gox convention. |
ytest/demo/foo/xgo_autogen.go |
Refreshes generated //line references to get_p_#id_yap.gox. |
ytest/demo/foo/get_p_#id_yap.gox |
Adds new handler classfile in _yap.gox convention for ytest demo. |
ytest/demo/jwtdemo/xgo_autogen.go |
Refreshes generated //line references to get_p_#id_yap.gox. |
ytest/demo/jwtdemo/get_p_#id_yap.gox |
Adds new handler classfile in _yap.gox convention for ytest demo. |
ytest/demo/match/hello/xgo_autogen.go |
Refreshes generated //line references to get_p_#id_yap.gox. |
ytest/demo/match/hello/get_p_#id_yap.gox |
Adds new handler classfile in _yap.gox convention for ytest demo. |
ytest/demo/match/diveinto/xgo_autogen.go |
Refreshes generated //line references to get_p_#id_yap.gox. |
ytest/demo/match/diveinto/get_p_#id_yap.gox |
Adds new handler classfile in _yap.gox convention for ytest demo. |
ytest/demo/_example/example_ytest.gox |
Updates example to use bearer auth helper and aligns with current ytest directives. |
ytest/demo/_example/xgo_autogen_test.go |
Refreshes generated test to CaseApp, bearer auth, and current match/concat helpers. |
ytest/demo/_example/xgo_autogen.go |
Adds/refreshes generated header for the example package. |
cmd/wechat/xgo_autogen.go |
Adds generated output for the wechat_yapt.gox command directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Remove the
.yapclassfile entries fromgox.modand rename the yap demo and test files to_yap.goxso the repository matches the preferred classfile convention.Update the README, manual, and
ytestdocs to use_yap.goxexamples andxgocommands throughout.Refresh the checked-in generated files and replace the leftover
gop_autogenoutputs inytest/demo/_examplewithxgo_autogenfiles by updating the example to use the current bearer auth helper.