fix: upgrade MOG to Probot 10 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bcoe
suggested changes
Sep 30, 2020
| @@ -857,7 +851,7 @@ describe('merge-on-green', () => { | |||
| )); | |||
|
|
|||
| await probot.receive({ | |||
| name: 'pull_request.labeled', | |||
| name: 'pull_request.labeled' as any, | |||
There was a problem hiding this comment.
I opened an issue related to this, and it seems like we should be able to work around the issue like this:
So I think hopefully the only actual issue is the repository.scheduled.
bcoe
approved these changes
Sep 30, 2020
| @@ -395,6 +397,7 @@ function cleanReviews(reviewsCompleted: Reviews[]): Reviews[] { | |||
| } | |||
| } | |||
| } | |||
| console.log(cleanReviews); | |||
There was a problem hiding this comment.
nit: I think we could use @azizsonawalla's logger here
import {logger} from 'gcf-utils';
☝️ at the top.
logger.error(e);
logger.info('foo')
There was a problem hiding this comment.
oops, that was a testing remnant. I can fix that, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.