feat: upgrade buildcop to probot 10 #1000
Conversation
google-cla
bot
added
the
cla: yes
…bots into upgrade-buildcop
…bots into upgrade-buildcop
sofisl
changed the title
| @@ -75,6 +79,139 @@ const GROUPED_MESSAGE = `Many tests failed at the same time in this package. | |||
|
|
|||
| `; | |||
|
|
|||
| interface IssuesListForRepoResponseItem { | |||
There was a problem hiding this comment.
We do we need to define this type? Seems like it should be a part of @octokit/types?
There was a problem hiding this comment.
Unfortunately, @octokit/types only defines the response to this method as an array, rather than a single item. We need to define this as well for those references.
| let issues = await context.github.paginate(options); | ||
| let issues = (await context.github.paginate( | ||
| options | ||
| )) as IssuesListForRepoResponseData; |
There was a problem hiding this comment.
I'm surprised we need this cast when we didn't before?
There was a problem hiding this comment.
This is because it's expecting a type of Promise<PaginationResults<unknown>> rather than the array of data that it will be.
| Octokit: require('@octokit/rest').Octokit, | ||
| probot = createProbot({ | ||
| githubToken: 'abc123', | ||
| Octokit: TestingOctokit as any, |
There was a problem hiding this comment.
A bunch of any lint warnings in this file, too.
There was a problem hiding this comment.
Yeah, unfortunately the 'any' is a known issue since the Github API event names have been locked down; see here: octokit/webhooks.js#277
There was a problem hiding this comment.
I'll add this as a comment in the file, though!
|
@tbpg Thanks for the review! I cut down on the |
No description provided.