Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: generate java-grafeas #10857

Merged
merged 11 commits into from
May 22, 2024
Merged

chore: generate java-grafeas #10857

merged 11 commits into from
May 22, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented May 17, 2024 •
edited

In this PR:

  • Add configuration to generate grafeas
  • Add allowed copyright holder

@JoeWang1127 JoeWang1127 changed the title chore: add grafeas chore: generate java-grafeas May 17, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review May 21, 2024 22:26
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner May 21, 2024 22:26
@suztomo
Copy link
Member

suztomo commented May 21, 2024

header-check failed: https://github.com/googleapis/google-cloud-java/pull/10857/checks?check_run_id=25250275482

java-grafeas/src/main/java/io/grafeas/v1/InTotoSlsaProvenanceV1.java has an invalid copyright holder: The Grafeas Authors
java-grafeas/src/main/java/io/grafeas/v1/InTotoSlsaProvenanceV1OrBuilder.java has an invalid copyright holder: The Grafeas Authors
java-grafeas/src/main/java/io/grafeas/v1/SBOMReferenceNote.java has an invalid copyright holder: The Grafeas Authors
java-grafeas/src/main/java/io/grafeas/v1/SBOMReferenceNoteOrBuilder.java has an invalid copyright holder: The Grafeas Authors

JoeWang1127
JoeWang1127 commented May 21, 2024
View reviewed changes
.github/header-checker-lint.yml
@@ -0,0 +1,3 @@
allowedCopyrightHolders:
- 'Google LLC'
- 'The Grafeas Authors'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add allowed copyright holders, the header check passed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a header check bot configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please see https://github.com/googleapis/repo-automation-bots/tree/main/packages/header-checker-lint#configuration

@JoeWang1127 JoeWang1127 requested a review from suztomo May 21, 2024 23:08
blakeli0
blakeli0 reviewed May 22, 2024
View reviewed changes
java-grafeas/.repo-metadata.json
"api_description": "n/a",
"client_documentation": "https://cloud.google.com/java/docs/reference/grafeas/latest/overview",
"release_level": "stable",
"transport": "grpc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that transport and requires_billing are new, is it because they are always generated now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we get the default value false for requires_billing? I thought it is true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value is true.

I set it to false in generation config.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it as true because it does requires billing if you go to the api console. Or we can leave it as not generated for now, and change the generator logic to not generate requires_billing if it is not specified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it requires billing, I'll change it to true by removing it from config. The value is true by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@JoeWang1127 JoeWang1127 requested a review from blakeli0 May 22, 2024 13:00
@JoeWang1127 JoeWang1127 merged commit 3627904 into main May 22, 2024
31 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/add-grafeas branch May 22, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

@suztomo suztomo Awaiting requested review from suztomo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoeWang1127 @suztomo @blakeli0 @cloud-java-bot