Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): #10213

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented May 16, 2024

TestReadRows_Retry_LastScannedRow_Reverse

https://github.com/googleapis/cloud-bigtable-clients-test/blob/9722a183ac2f3d7edf9f2816d2748f4729b15a61/tests/readrows_test.go#L171-L173

fails with error:

--- FAIL: TestReadRows_NoRetry_ErrorAfterLastRow (0.03s)
    readrows_test.go:201: 
        	Error Trace:	cloud-bigtable-clients-test/tests/readrows_test.go:201
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestReadRows_NoRetry_ErrorAfterLastRow
--- FAIL: TestReadRows_Retry_LastScannedRow_Reverse (0.04s)

The test sends below request to Go Bigtable proxy:

Request: &btpb.ReadRowsRequest{
	TableName: buildTableName("table"),
	RowsLimit: 1,
},

On receiving the request, the proxy creates a ReadRows request for the client library and invokes ReadRows function.
Even though test sends RowsLimit field in the method, the proxy does not add it to the client library request. This has been fixed in this PR.

On receiving deadline exceeded, Bigtable client

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant