Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support method provider #295

Closed
wants to merge 1 commit into from
Closed

feat: support method provider #295

wants to merge 1 commit into from

Conversation

sin5th
Copy link

@sin5th sin5th commented May 31, 2021

implement #294

Summary

  • qualifiedIdentObject supports *ast.ParenExpr for Struct method, and *ast.SelectorExpr for Struct pointer method.
  • processFuncProvider supports function with recv.
  • qualifiedID supports ID looks like (*animals.Animals).NewDog and (animals.Animals).NewCat

Tests

  • TestMethodProvider with cmd/wire.go
  • tests/method_provider directory store test case. include a wire.go and animals package for test

@google-cla
Copy link

google-cla bot commented May 31, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Cannot accept contribution until Google CLA is signed. label May 31, 2021
Change-Id: I04341c6de67ab2f75bf5da0957ac502f4f5b9ae8
@google-cla google-cla bot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels May 31, 2021
@sin5th
Copy link
Author

sin5th commented May 31, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@sin5th sin5th closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant