feat: Add support for UUID Version 8 (RFC 9562) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwingopalsamy
commented
Dec 14, 2024
There was a problem hiding this comment.
Hi @bormanp, apologies for the noise! I’d really appreciate it if you could take a look at this proposal when you have a moment. Thanks in advance! 🙏
|
any news ? uuid v8 really useful when need to store in db and have ordered records with uniq node id |
This was referenced Dec 24, 2024
|
hi team, would appreciate your eyes on this proposal. @quartzmo / @bormanp / @noahdietz :) |
|
Hello 👋 Would appreciate some review here :) |
cristaloleg
reviewed
Feb 19, 2025
version8.go
Outdated
| timestamp := uint64(time.Now().UnixNano()) | ||
|
|
||
| timeMu.Lock() | ||
| defer timeMu.Unlock() |
There was a problem hiding this comment.
Can we release lock after the if below?
There was a problem hiding this comment.
Not like that. Drop defer, it's not needed after the if.
cristaloleg
reviewed
Feb 19, 2025
version8.go
Outdated
| } | ||
|
|
||
| // makeV8 generates a version 8 UUID using user-provided or random data for custom_a, custom_b, and custom_c. | ||
| func makeV8(uuid []byte, customA, customB, customC []byte) { |
There was a problem hiding this comment.
Ah yes! This wasn't supposed to be here. Removed it.
remove redundant function (dead code) and place the `sync.Mutex` lock after the `if` condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for generating UUID Version 8 as defined in RFC 9562. UUIDv8 is designed for custom or experimental use cases, allowing you to embed application-specific data while adhering to standard version and variant bits.
What’s included:
NewV8(): Generates a UUIDv8 with random values.NewV8FromReader(customA, customB, r): Allows custom values forcustom_a(48 bits) andcustom_b(12 bits) whilecustom_cfield (62 bits) is filled using a random source or secure fallback.NewV8TimeBased(r): A time-based variant ofUUIDv8that uses the current timestamp forcustom_a. It also includes a sequence number to ensure uniqueness when multiple UUIDs are generated in the same nanosecond.This addition completes support for all UUID versions in RFC 9562. Looking forward for your feedback, team!