Improve analyzer result querying performance #3012
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Load analyzer results via the new API endpoint * Fixing a small frontend bug
berggren
requested changes
Jan 8, 2024
| for timeline in sketch.timelines: | ||
| for analyzer_name in sketch_analyzer_names: | ||
| analysis_history = ( | ||
| Analysis.query.filter_by(timeline=timeline, name=analyzer_name) |
There was a problem hiding this comment.
Did you find a way to make this into a more efficient query instead of loop in code?
There was a problem hiding this comment.
Sadly not. Still looking into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analyzer results are currently requested per timeline when a sketch is loaded. This results in some scaling issues when working with a sketch that has many timelines.
This PR improves the loading performance by adding a new API endpoint that returns only the latest analyzer session for each timeline and analyzer on a given sketch.
LatestAnalyzerSketchResourceAPI endpoint.