Skip to content

Commit

Permalink
Binary operations take the name of the left feature
Browse files Browse the repository at this point in the history
  • Loading branch information
javiber committed Apr 4, 2024
1 parent ce03dca commit ea7a47e
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions temporian/core/operators/binary/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def __init__(
# outputs
output_features = [ # pylint: disable=g-complex-comprehension
FeatureSchema(
name=self.output_feature_name(feature_1, feature_2),
name=feature_1.name,
dtype=self.output_feature_dtype(feature_1, feature_2),
)
for feature_1, feature_2 in zip(
Expand Down Expand Up @@ -107,11 +107,6 @@ def operator_def_key(cls) -> str:
def prefix(self) -> str:
"""Gets the prefix to use for the output features."""

def output_feature_name(
self, feature_1: FeatureSchema, feature_2: FeatureSchema
) -> str:
return f"{self.prefix}_{feature_1.name}_{feature_2.name}"

def output_feature_dtype(
self, feature_1: FeatureSchema, feature_2: FeatureSchema
) -> DType:
Expand Down

0 comments on commit ea7a47e

Please sign in to comment.