Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bazel 8, remove deprecated rules_proto #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fhanau
Copy link
Contributor

@fhanau fhanau commented Nov 28, 2024

Improve dependency management to support Bazel 8 properly, this is now working at least with bzlmod.

  • Update rules_fuzzing to fix version compatibility issue with protobuf
  • rules_proto is deprecated. Import rules directly from protobuf as is intended with Bazel 8. Update protobuf to 27.5 since 26.0 does not define the required rules.
  • Import fuzztest in bzlmod – this way WORKSPACE.bzlmod is now empty.
  • Cleanup: remove redundant absl/debugging:leak_check dependency from tcmalloc library

Improve dependency management to support Bazel 8 properly, this is now working
at least with bzlmod.

- Update rules_fuzzing to fix version compatibility issue with protobuf
- rules_proto is deprecated. Import rules directly from protobuf as is intended
  with Bazel 8. Update protobuf to 27.5 since 26.0 does not define the required
  rules.
- Import fuzztest in bzlmod – this way WORKSPACE.bzlmod is now empty.
- Cleanup: remove redundant absl/debugging:leak_check dependency from tcmalloc
  library
@fhanau
Copy link
Contributor Author

fhanau commented Dec 11, 2024

Would love to get a review on this – Bazel 8 has been released on Monday, I'm sure tcmalloc will want to support it in the future.

copybara-service bot pushed a commit that referenced this pull request Dec 13, 2024
PiperOrigin-RevId: 705666450
Change-Id: I8cb64dad9b084fc82445295749c484751fa48f4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants