Ensure ThreadCache constructor runs.

LinkedList's default constructor initializes state. Freshly allocated ThreadCache's either come from mmap (SystemAlloc) and all-zeroes are valid or are reused and have been initialized. PiperOrigin-RevId: 573026806 Change-Id: I8b92ec3e8535a89ab1c78311b33287997e6915a1
google · Oct 12, 2023 · 5b4b217 · 5b4b217
1 parent d697cb9
commit 5b4b217
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/tcmalloc/testing/BUILD b/tcmalloc/testing/BUILD
@@ -909,7 +909,6 @@ cc_test(
     srcs = ["parallel_test.cc"],
     copts = TCMALLOC_DEFAULT_COPTS,
     malloc = "//tcmalloc/internal:system_malloc",
-    tags = ["nomsan"],
     deps = [
         "//tcmalloc:tcmalloc_internal_methods_only",  # buildcleaner: keep
         "@com_google_absl//absl/base:config",

diff --git a/tcmalloc/testing/parallel_test.cc b/tcmalloc/testing/parallel_test.cc
@@ -67,10 +67,6 @@ struct Allocator {
 };
 
 TEST(ParallelTest, Stable) {
-#ifdef ABSL_HAVE_MEMORY_SANITIZER
-  // TODO(b/148986845):  Enable this.
-  GTEST_SKIP() << "Skipping under msan.";
-#endif
 #ifdef ABSL_HAVE_THREAD_SANITIZER
   // TODO(b/274996721):  Enable this when Span::nonempty_index_ does not
   // conflict with other bitfields.

diff --git a/tcmalloc/thread_cache.cc b/tcmalloc/thread_cache.cc
@@ -37,7 +37,7 @@ ABSL_CONST_INIT thread_local ThreadCache* ThreadCache::thread_local_data_
 ABSL_CONST_INIT bool ThreadCache::tsd_inited_ = false;
 pthread_key_t ThreadCache::heap_key_;
 
-void ThreadCache::Init(pthread_t tid) {
+ThreadCache::ThreadCache(pthread_t tid) {
   size_ = 0;
 
   max_size_ = 0;
@@ -299,7 +299,7 @@ ThreadCache* ThreadCache::CreateCacheIfNecessary() {
 ThreadCache* ThreadCache::NewHeap(pthread_t tid) {
   // Create the heap and add it to the linked list
   ThreadCache* heap = tc_globals.threadcache_allocator().New();
-  heap->Init(tid);
+  new (heap) ThreadCache(tid);
   heap->next_ = thread_heaps_;
   heap->prev_ = nullptr;
   if (thread_heaps_ != nullptr) {

diff --git a/tcmalloc/thread_cache.h b/tcmalloc/thread_cache.h
@@ -41,7 +41,8 @@ namespace tcmalloc_internal {
 
 class ThreadCache {
  public:
-  void Init(pthread_t tid) ABSL_EXCLUSIVE_LOCKS_REQUIRED(pageheap_lock);
+  explicit ThreadCache(pthread_t tid)
+      ABSL_EXCLUSIVE_LOCKS_REQUIRED(pageheap_lock);
   void Cleanup();
 
   // Accessors (mostly just for printing stats)