Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syz-manager: handle failed requests #4813

Merged
merged 1 commit into from
May 17, 2024

Conversation

a-nogikh
Copy link
Collaborator

If syz-fuzzer has not been able to execute the request, set the proper result status.

Assign fallback signal only if signal was requested and if the execution was successful.

@a-nogikh a-nogikh requested a review from dvyukov May 16, 2024 16:47
@a-nogikh
Copy link
Collaborator Author

Locally tested that it does fix the breakage.

@a-nogikh a-nogikh enabled auto-merge May 16, 2024 16:49
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 61.1%. Comparing base (ad5321c) to head (f22f733).
Report is 1 commits behind head on master.

Current head f22f733 differs from pull request most recent head 8467c33

Please upload reports for the commit 8467c33 to get more accurate results.

Additional details and impacted files
Files Coverage Δ
syz-manager/rpc.go 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

@a-nogikh a-nogikh disabled auto-merge May 16, 2024 17:06
dvyukov
dvyukov previously approved these changes May 17, 2024
If syz-fuzzer has not been able to execute the request, set the proper
result status.

Assign fallback signal only if signal was requested and if the execution
was successful.
@a-nogikh
Copy link
Collaborator Author

Fixed conflicts with the latest merged PR. PTAL.

@a-nogikh a-nogikh enabled auto-merge May 17, 2024 09:01
@a-nogikh a-nogikh added this pull request to the merge queue May 17, 2024
Merged via the queue into google:master with commit 4130c19 May 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants