Two minor fixes for the pkg-config module generation #1529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
13 tasks
After v2023.8 2024-01-03 you have stopped appending the date to version in CHANGES file which means the newer ones are ignored when extracting the version for pkg-config module generation. Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Analogous to KhronosGroup/SPIRV-Tools#6483 Signed-off-by: Marcin Serwin <marcin@serwin.dev>
marcin-serwin
force-pushed
the
push-lsuxxmssvqrl
branch
from
3210139 to
ddde702
Compare
Collaborator
|
The first fix is clearly good. I need to take time to understand the second one in depth. I can't accept any of the changes until you accept the CLA |
Author
I won't sign the CLA. I release these patches into public domain via Unlicense, do with them what you will. |
dneto0
added a commit
to dneto0/shaderc
that referenced
this pull request
Jan 21, 2026
It must appear on the third line. This will prevent accidentally dropping the date. The missing dates have been messing up the version number generation for pkg-config processing. See google#1529
dneto0
added a commit
to dneto0/shaderc
that referenced
this pull request
Jan 22, 2026
It must appear on the third line. This will prevent accidentally dropping the date. The missing dates have been messing up the version number generation for pkg-config processing. See google#1529
dneto0
added a commit
that referenced
this pull request
Jan 22, 2026
It must appear on the third line. This will prevent accidentally dropping the date. The missing dates have been messing up the version number generation for pkg-config processing. See #1529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the commit messages