Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual analogue scale (Android, Server) #1536

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Visual analogue scale (Android, Server) #1536

wants to merge 5 commits into from

Conversation

JodliDev
Copy link

Adds the option to create a Visual Analogue Scale for android as an Input-Element
(needs min-APIVersion 16)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@JodliDev
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

BobEvans
BobEvans reviewed Mar 22, 2017
View reviewed changes
Copy link
Collaborator

@BobEvans BobEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! We would love to have this new input element.

We have to check with existing users to see if they can move to SDK 16 minimum. Some do a lot of research in India where 4.0 was still fairly prevalent not too long ago.

Paco/AndroidManifest.xml Outdated
@@ -365,5 +365,5 @@
<uses-permission android:name="android.permission.READ_CALENDAR" />

<uses-feature android:name="android.hardware.camera" android:required="false"/>
<uses-sdk android:minSdkVersion="14" android:targetSdkVersion="22"></uses-sdk>
<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="22"></uses-sdk>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something in this change that requires sdk 16? If not, please revert so we are supporting back to Android 4.0.

@JodliDev
Copy link
Author

The SeekBar.getThumb()-function needed API 16.
But I created a fix that also works in API 14 :)

@josmas
Copy link

josmas commented Mar 20, 2018 •
edited
Loading

Hi @JodliDev this is very cool. Is there any code to show the scale in the Preview (server side). All I can see is the question text, but nothing under it.
Are you planning on adding any more configurable attributes like scale or indicator text?

josmas added a commit to josmas/paco that referenced this pull request Mar 20, 2018
@josmas
adds a Seekbar component (app side, no preview available server side…
599fb7a 
…), taken

 from google#1536 but modified, bumping Android
 version to API level 16
@josmas
Copy link

josmas commented Mar 20, 2018

In case you are interested, I added a default material slider to the server preview here: josmas@9c2b33b

Also fixed the services.js conflict but I bumped to API 16 and set limits to 0-100 for now, cause it is what I need. Happy to back port or add functionality if there's a need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobEvans BobEvans BobEvans left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JodliDev @googlebot @josmas @BobEvans