KSP2: fix KSValueParameter.isVal and isVar #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for symbols from libraries.
jsjeon
reviewed
Mar 14, 2025
| val cstr = ktValueParameterSymbol.containingDeclaration as? KaConstructorSymbol | ||
| val cls = cstr?.containingDeclaration as? KaClassSymbol | ||
| cls?.declaredMemberScope?.declarations?.filterIsInstance<KaPropertySymbol>() | ||
| ?.firstOrNull { it.name == ktValueParameterSymbol.name } |
There was a problem hiding this comment.
In addition to name check, you can use isFromPrimaryConstructor: https://github.com/JetBrains/kotlin/blob/master/analysis/analysis-api/src/org/jetbrains/kotlin/analysis/api/symbols/KaVariableSymbol.kt#L245 ?
There was a problem hiding this comment.
Unfortunately isFromPrimaryConstructor is also PSI based and doesn't work on libraries.
But that reminds me of a case that this patch doesn't cover:
class MyClass(prop: Int = 1) {
val prop: Int = 0
}
IMHO it is impossible to distinguish without adding metadata in the libraries.
Anyway, this patch covers most of the use cases and doesn't introduce new issues. If there are no other concerns, I'm going to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for symbols from libraries.
Fixes #1192 and #2348