Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for compiler warnings in thread_pool.h #2528

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Fixes for compiler warnings in thread_pool.h #2528

merged 5 commits into from
Mar 11, 2025
+10 −6

Conversation

johnplatts
Copy link
Contributor

Fixes compiler warning with Clang in ThreadPool::SendConfig as the task parameter in the closure lambda is unused in debug builds.

@johnplatts johnplatts changed the title Fixed unused parameter warning in ThreadPool::SendConfig Fixes for compiler warnings in thread_pool.h Mar 11, 2025
jan-wassenberg
jan-wassenberg reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! One suggestion/comment:

jan-wassenberg
jan-wassenberg approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change :)

@copybara-service copybara-service bot merged commit 49cfb4b into google:master Mar 11, 2025
36 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-wassenberg jan-wassenberg

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnplatts @jan-wassenberg @miladfarca