Skip to content

Fixes for Mac issues #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2017
Merged

Fixes for Mac issues #55

merged 2 commits into from
Mar 17, 2017

Conversation

robryk
Copy link
Contributor

@robryk robryk commented Mar 17, 2017

This should fix various build problems on Mac (#39 and #41).

robryk added 2 commits March 17, 2017 21:24
@robryk
Work around mysterious Mac build error.
f4b5115 
This is a workaround for google#41. I don't understand why it should help. The
only downside is that it increased on-disk binary size (but not
in-memory size).
@robryk
Use pkg-config for LDFLAGS and CXXFLAGS
0431c6c 
This should cause the build to work in cases when one needs to provide
custom library and include directories. This should fix google#39.
@robryk robryk requested a review from jyrkialakuijala March 17, 2017 20:25
@jyrkialakuijala jyrkialakuijala merged commit c78689c into google:master Mar 17, 2017
robryk added a commit to robryk/guetzli that referenced this pull request Mar 17, 2017
@robryk
No longer necessary to specify libs and include paths.
f915ef6 
PR google#55 fixed this.
@kornelski
Copy link

There's no libgflags. The package is called gflags

libpng works though.

pkg-config --libs libpng gflags

@ignisf ignisf mentioned this pull request Mar 18, 2017
Closed
5 tasks
@robryk
Copy link
Contributor Author

robryk commented Mar 18, 2017

Oh gosh; even this is not consistent between environments (on my Ubuntu it's the exact reverse: there is libgflags.pc but not gflags.pc).

@kornelski
Copy link

Ahh, joys of C dependencies :)

This works for me on macOS:

pkg-config --silence-errors --libs libgflags || pkg-config --libs gflags

@robryk
Copy link
Contributor Author

robryk commented Mar 18, 2017

Ah, thanks, that's better than specifying both with --silence-errors.

@kornelski kornelski mentioned this pull request Mar 18, 2017
Closed
robryk added a commit to robryk/guetzli that referenced this pull request Mar 18, 2017
@robryk
Fix pkg-config library name
b98c47b 
It turns out that some environments have gflags.pc and some have
libgflags.pc. So, try both. Fixes google#61 and fixes google#55.
robryk added a commit to robryk/guetzli that referenced this pull request Mar 18, 2017
@robryk
Fix pkg-config library name
b0dfcf5 
It turns out that some environments have gflags.pc and some have
libgflags.pc. So, try both. Fixes google#61 and fixes google#55.
@robryk robryk mentioned this pull request Mar 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyrkialakuijala jyrkialakuijala jyrkialakuijala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robryk @kornelski @jyrkialakuijala