Add CUDA & OpenCL support #223

crazyks · 2017-07-10T12:17:14Z

Recreate a pull #227.

# Conflicts: # clguetzli/clguetzli.cl # clguetzli/clguetzli.cpp

"edgeDetectorMap" "blockDiffMap" "edgeDetectorLowFreq"

# Conflicts: # clguetzli/clguetzli.cl # clguetzli/clguetzli.cpp # clguetzli/ocl.h

googlebot · 2017-07-10T12:18:20Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

kornelski · 2017-07-10T14:11:30Z

Hi @crazyks! That's an awesome functionality.

But this pull request contains more than 250 new files! There is a lot of new files in third_party folder, including libjpeg, zlib, and binary files. That's probably not intentional? Could you delete these and squash or fixup the commits?

crazyks · 2017-07-11T01:01:50Z

Hi @pornel. Thanks for your reply. We will remove some redundant files:)

googlebot · 2017-07-11T01:02:56Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot · 2017-07-11T03:13:22Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2017-07-11T03:16:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

crazyks · 2017-07-11T07:01:36Z

We signed the CLA

crazyks · 2017-07-12T01:51:55Z

update CLA

This reverts commit 5aed0cb.

According to the CI fail log. no pngtopnm command in the test environment, so add netpbm package and try again.

googlebot · 2017-07-13T03:27:09Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2017-07-13T04:53:30Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot · 2017-07-13T11:40:15Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

ianhuang-777 · 2017-07-14T02:33:17Z

I signed it!

rogierlommers · 2017-08-03T06:27:11Z

So any e.t.a. about when we can get a new (official) release which supports CUDA & OpenCL?

ianhuang-777 and others added 30 commits May 5, 2017 14:59

Remove comment

66b837a

Merge branch 'master' of https://github.com/ianhuang-777/guetzli

cf0d643

先提交对比下ian的实现方式

e98af1e

Merge branch 'master' of https://github.com/ianhuang-777/guetzli

4e4901a

# Conflicts: # clguetzli/clguetzli.cl # clguetzli/clguetzli.cpp

Implement clMaskHighIntensityChangeEx

59f44ef

Implement clDiffPrecomputeEx

7172f12

Implement clDiffPrecomputeEx

9906f02

Implement clCalculateDiffmapEx

5226606

Implement clAverage5x5Ex

385da09

implement kernel function:

d2777c6

"edgeDetectorMap" "blockDiffMap" "edgeDetectorLowFreq"

Merge branch 'master' of https://github.com/ianhuang-777/guetzli

7bff568

# Conflicts: # clguetzli/clguetzli.cl # clguetzli/clguetzli.cpp # clguetzli/ocl.h

test for clDiffmapOpsinDynamicsImage

21f9a3e

fix runtime bug

fa130a0

remove useless code

90b5a6c

添加测试用例

8775fc5

增加测试用例

0e57019

修改测试用例框架

45dcb8f

测试用例分工

33efa14

MapBuffer之后要进行Unmap

9bced88

先排查>100*100的计算精度问题

a583957

Remove _constant for opencl 1.2

7d52abe

Remove _constant for opencl 2.0

386a3c2

修复nVidia显卡的问题

0af3c20

fixed n卡 __constant的问题

56c6ffc

Fix __constant error for nvidia device

a51d442

Optimize clDoMask

9f21b23

32位平台编译配置

b928e91

Merge branch 'master' of https://github.com/ianhuang-777/guetzli

7ef8367

Move some local constant array to __constant

8fb8c98

for test

7bf62d0

ianhuang-777 and others added 2 commits July 11, 2017 10:36

Translate the comment.

dcdd10a

Remove some redundant files

e5f5f11

Modify makefile

d999f09

Update Readme

5aed0cb

crazyks added 6 commits July 13, 2017 00:41

Revert "Update Readme"

37392b9

This reverts commit 5aed0cb.

Disable CUDA & OpenCL by default

b621bfa

Disable CUDA & OpenCL by default

bb847e4

Add netpbm

4b1d183

According to the CI fail log. no pngtopnm command in the test environment, so add netpbm package and try again.

Fix type cast error on Mac

14f0998

Update bazel version to 0.5.2

add1272

Add oracle-java8-installer

17b651b

crazyks added 4 commits July 13, 2017 13:02

Try to remove openjdk-9-jdk because of conflict

6fb651c

Remove oracle-java9-installer because of conflict

c85df44

Try to fix Bazel build

2571a24

Add author information

de876fa

Update ReadMe

1b72a92

crazyks closed this Jul 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CUDA & OpenCL support #223

Add CUDA & OpenCL support #223

crazyks commented Jul 10, 2017 •

edited

Loading

googlebot commented Jul 10, 2017

kornelski commented Jul 10, 2017

crazyks commented Jul 11, 2017 via email •

edited

Loading

googlebot commented Jul 11, 2017

googlebot commented Jul 11, 2017

googlebot commented Jul 11, 2017

crazyks commented Jul 11, 2017

crazyks commented Jul 12, 2017

googlebot commented Jul 13, 2017

googlebot commented Jul 13, 2017

googlebot commented Jul 13, 2017

ianhuang-777 commented Jul 14, 2017

rogierlommers commented Aug 3, 2017

Add CUDA & OpenCL support #223

Add CUDA & OpenCL support #223

Conversation

crazyks commented Jul 10, 2017 • edited Loading

googlebot commented Jul 10, 2017

kornelski commented Jul 10, 2017

crazyks commented Jul 11, 2017 via email • edited Loading

googlebot commented Jul 11, 2017

googlebot commented Jul 11, 2017

googlebot commented Jul 11, 2017

crazyks commented Jul 11, 2017

crazyks commented Jul 12, 2017

googlebot commented Jul 13, 2017

googlebot commented Jul 13, 2017

googlebot commented Jul 13, 2017

ianhuang-777 commented Jul 14, 2017

rogierlommers commented Aug 3, 2017

crazyks commented Jul 10, 2017 •

edited

Loading

crazyks commented Jul 11, 2017 via email •

edited

Loading