Repository navigation
query: skip unexported embedded scalar fields - #194
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Embedding
type hidden stringin an options struct makesquery.Valuespanic on reflection access to that private field. A nil pointer to the same type adds an unexpected parameter.The visibility filter now skips private scalar embeds. Promoted public fields of private embedded structs still encode normally.
I added eight cases. Five fail on unchanged master, including four panics. The remaining cases check exported scalar fields and promoted struct fields.
The CI command
go test -v -race -coverprofile coverage.txt -covermode atomic ./...passes on Go 1.13.15, 1.23.4 and 1.26.3. Each reports 100% statement coverage.golangci-lint2.1.2,golint,go build ./...andgo vet ./...also pass.