Skip to content

Set the secondary EOS for Gemma2 #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Set the secondary EOS for Gemma2 #527

merged 2 commits into from
Mar 25, 2025

Conversation

ufownl
Copy link
Contributor

@ufownl ufownl commented Mar 21, 2025

This PR also removes the <end_of_turn> filter that was set up specifically for Gemma2 and fixes the EOS checking.

jan-wassenberg
jan-wassenberg approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @pculliton, any thoughts?

pculliton
pculliton approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@pculliton pculliton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes - thank you for making them!

@jan-wassenberg jan-wassenberg added the copybara-import Trigger Copybara for merging pull requests label Mar 21, 2025
jan-wassenberg
jan-wassenberg reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a merge conflict, can you please rebase?

@jan-wassenberg jan-wassenberg removed the copybara-import Trigger Copybara for merging pull requests label Mar 21, 2025
ufownl added 2 commits March 22, 2025 01:32
@ufownl
Fix the EOS checking
2bad79f 
The secondary eos is usually `<end_of_turn>`, which can appear in the
prompt, so we can only check it not in the prompt.
@ufownl
Set the secondary EOS for Gemma2
d42deaa 
So that we can remove the `<end_of_turn>` filter that was set up
specifically for Gemma2.
@ufownl ufownl force-pushed the feature/gemma2_secondary_eos branch from cbb84e1 to d42deaa Compare March 21, 2025 17:33
@ufownl
Copy link
Contributor Author

ufownl commented Mar 21, 2025

I have rebased, but no conflict complained by git.

jan-wassenberg
jan-wassenberg approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It could be that our copybara import was stuck, hopefully this will unblock it.

@jan-wassenberg jan-wassenberg added the copybara-import Trigger Copybara for merging pull requests label Mar 21, 2025
@copybara-service copybara-service bot merged commit 4a924f1 into google:dev Mar 25, 2025
6 of 8 checks passed
Fendyzainol9
Fendyzainol9 approved these changes May 1, 2025
View reviewed changes
Copy link

@Fendyzainol9 Fendyzainol9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu with anuar ibrahim , It is not allowed to interfere.

@Fendyzainol9 Fendyzainol9 mentioned this pull request May 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pculliton pculliton pculliton approved these changes

@jan-wassenberg jan-wassenberg jan-wassenberg approved these changes

@Fendyzainol9 Fendyzainol9 Fendyzainol9 approved these changes

Assignees
No one assigned
Labels
copybara-import Trigger Copybara for merging pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ufownl @pculliton @jan-wassenberg @Fendyzainol9