Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added identity export from JAX #4652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jlperla
Copy link
Contributor

@jlperla jlperla commented Mar 25, 2025

Fixes #4635

This re-exports the JAX identity "activation" which was merged in jax-ml/jax#27355

This was the only impact I could find in the Flax code itself. However, given that this has just been merged to JAX (and is not yet part of a tagged release) I am not sure about the merging process and its interaction with version compatibility, etc. @IvyZX

@IvyZX
Copy link
Collaborator

IvyZX commented Mar 26, 2025

I'm happy to approve this, but FYI we won't be able to merge it until JAX make another release that includes the identity function.
And by that time you might also want to update our pyproject.toml to bump the required JAX version to the latest.

@IvyZX IvyZX self-assigned this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a nnx.identity "activation"?
2 participants