Initial JSONB support for typed_sql. #291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
May 31, 2025
| /// Return `true` and consume next column, if next column is `null`. | ||
| bool tryReadNull(); | ||
| } | ||
|
|
||
| class JsonValue { |
There was a problem hiding this comment.
nit: Final, implementation or base, but pick one and reason why :)
There was a problem hiding this comment.
Should be documented, not sure if we want it in adapter or typed_sql library..
We definitely need to explicitly document what types are allowed in value including what type parameters map and list must have.
We should not allow adapter specific behaviour here.
There was a problem hiding this comment.
Updated (also moved), PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note there are a few question in this code, e.g.:
JsonValueSubjectExt.JsonValuewrapper is the best way to approach this.jsonbcodec for sqlite is used correctly.However, I think this may be a good start to start supporting it.